Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ista EcoTrend quality scale record #131580

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Nov 25, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r requested a review from a team as a code owner November 25, 2024 21:35
@MartinHjelmare MartinHjelmare changed the title Record status quo on integration quality scale for ista EcoTrend inte… Add ista EcoTrend quality scale record Nov 25, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set the items to todo and merge this PR so we can fix this in followups

Comment on lines +52 to +54
discovery:
status: exempt
comment: The integration is a web service, there are no discoverable devices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the device communicate with the webservice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the metering devices? They report with some proprietary/encrypted radio signal to a central unit in the stairwell. And that unit submits the collected data to ista. But there is no link between the webservice and the individual devices. The webservice only gives you a monthly total consumption.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does that go via your local network?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, completely independent. The central unit in the stairwell collects data from all apartments in the building, it is in no ones network. I assume it reports to ista with a built in cellular modem.

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 4, 2024 13:52
@tr4nt0r tr4nt0r marked this pull request as ready for review December 4, 2024 14:34
@home-assistant home-assistant bot requested a review from joostlek December 4, 2024 14:34
@joostlek joostlek merged commit bd1ad04 into home-assistant:dev Dec 4, 2024
30 checks passed
@tr4nt0r tr4nt0r deleted the ista_iqs branch December 4, 2024 17:25
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants