Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deebot-client to 9.0.0 #131525

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Bump deebot-client to 9.0.0 #131525

merged 1 commit into from
Nov 25, 2024

Conversation

edenhaus
Copy link
Contributor

Breaking change

Ecovacs devices not recognized by the library will no longer use the fallback vacuum. Instead, the device will not be added to Home Assistant, and a warning log will created.

Proposed change

Release: https://github.com/DeebotUniverse/client.py/releases/tag/9.0.0
The reason for the breaking change is that the fallback created more issues than it solved.
Examples:

  • Mower/Win bot mapped as vacuum
  • Due to incorrect mapping used the wrong command -> a lot of errors in the logs
  • Continuously bug reports on not working features
    ....

By adding the model to the library we can use the correct commands and provide the correct entities

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @mib1185, @Augar, mind taking a look at this pull request as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

)
self._legacy_devices.append(bot)
for device_config in devices.not_supported:
_LOGGER.warning(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a repair issue would be helpful here, since it is direct user visible and could link to the troubleshooting section in the docs, were the user can find instructions how to request or contribute the support of the model to the lib?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only raise repair issues which the user can fix. This is not the case here and therefore I choose to create only a log entry

@edenhaus
Copy link
Contributor Author

Test failure unrelated

@edenhaus edenhaus marked this pull request as ready for review November 25, 2024 12:12
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @edenhaus 👍

@edenhaus edenhaus merged commit 2bf7518 into dev Nov 25, 2024
59 of 61 checks passed
@edenhaus edenhaus deleted the edenhaus-ecovacs-9.0.0 branch November 25, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants