-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deebot-client to 9.0.0 #131525
Bump deebot-client to 9.0.0 #131525
Conversation
Hey there @mib1185, @Augar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
) | ||
self._legacy_devices.append(bot) | ||
for device_config in devices.not_supported: | ||
_LOGGER.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a repair issue would be helpful here, since it is direct user visible and could link to the troubleshooting section in the docs, were the user can find instructions how to request or contribute the support of the model to the lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only raise repair issues which the user can fix. This is not the case here and therefore I choose to create only a log entry
Test failure unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx @edenhaus 👍
Breaking change
Ecovacs devices not recognized by the library will no longer use the fallback vacuum. Instead, the device will not be added to Home Assistant, and a warning log will created.
Proposed change
Release: https://github.com/DeebotUniverse/client.py/releases/tag/9.0.0
The reason for the breaking change is that the fallback created more issues than it solved.
Examples:
....
By adding the model to the library we can use the correct commands and provide the correct entities
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: