-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metoffice to use DataHub API #131425
base: dev
Are you sure you want to change the base?
Conversation
Hey there @exxamalte, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @MrHarcombe, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I'm happy to include this version bump here. Alternatively I could create a separate version bump PR, I simply haven't had a chance to do that yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding the time to get this done - appreciate it 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay let's get the twice daily in as well. I do still have some small comments
I get that you want to get as much in as possible, but to get the review in a decent way, please strip out new features from this PR and let's take them in follow-up PR's instead. |
Since I merged dependency bump in a separate PR, would it be possible to remove |
Breaking change
MetOffice is deprecating Datapoint API currently used by this integration and it's going to stop working in March 2025.
To keep integration working, it's now migrated to DataHub API.
To keep integration working, you will need to provide it a new API key which can be obtained by signing up for DataHub and subscribing to Global spot dataset. Free subscription provides 360 calls per day which is enough for this integration to work.
Some sensors have changed due to new data source:
visibility
andvisibility_distance
sensors showing a range and qualitative description (such as "1-4 km" and "Poor"), integration now exposes a singlevisibility
sensor with precise visibility distance in metersSite ID
,Site name
andSensor ID
attributes as these don't provide any additional valueProposed change
datapoint-python 0.12.1
.I had to bump
aio-geojson-generic-client
dependency from 0.4 to 0.5 to avoid conflicts. Changelog explicitly references Home Assistant dependency conflicts as a primary reason for update so I don't expect this to cause issues.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: