Add quality scale to Onkyo #131322
Merged
Add quality scale to Onkyo #131322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
previously requested changes
Nov 23, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
I responded with explanations for why things were marked the way they were marked. Please give them a thought. If you still disagree, let me know and I will change it according to your suggestions. |
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
requested changes
Dec 4, 2024
Co-authored-by: Franck Nijhof <[email protected]>
joostlek
approved these changes
Dec 5, 2024
zweckj
pushed a commit
to zweckj/home-assistant-core
that referenced
this pull request
Dec 5, 2024
* Add quality scale to Onkyo * Update homeassistant/components/onkyo/quality_scale.yaml Co-authored-by: Joost Lekkerkerker <[email protected]> * docs limitations todo Co-authored-by: Franck Nijhof <[email protected]> * entity event setup --------- Co-authored-by: Joost Lekkerkerker <[email protected]> Co-authored-by: Franck Nijhof <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add quality scale to Onkyo
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: