Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioairq to 0.4.3 #130963

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Sibgatulin
Copy link
Contributor

@Sibgatulin Sibgatulin commented Nov 19, 2024

Proposed change

Bump aioairq version to 0.4.3. This fixes #130344 by homogenising the keys of particulate matter values that come from different sensor models.

Here is the diff to the previous version, namely 0.3.2. It captures, however, a fair bit of contributed functionality that isn't directly relevant to the aforementioned issue. This, 0.4.2 vs 0.4.3, diff is far more relevant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration (airq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek
Copy link
Member

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@Sibgatulin
Copy link
Contributor Author

Thank you for the quick reply @joostlek. Fair point, I've updated the PR description with the diff to the latest version used. (I had presumed that the latest commit would suffice because it captures the changes, relevant to the issue.)

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@joostlek joostlek added this to the 2024.11.3 milestone Nov 19, 2024
@joostlek joostlek merged commit 4adf199 into home-assistant:dev Nov 19, 2024
65 checks passed
@Sibgatulin
Copy link
Contributor Author

Thanks for the quick review!

@Sibgatulin Sibgatulin deleted the airq_version_bump branch November 20, 2024 11:23
eclair4151 pushed a commit to eclair4151/home-assistant-core that referenced this pull request Nov 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing PM entities from airQ radon science additional sensor
3 participants