-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update elmax_api to v0.0.6.1 #130917
Update elmax_api to v0.0.6.1 #130917
Conversation
Hey there @albertogeniola, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
PS. Please also ensure that you run python -m script.gen_requirements_all
to update the requirements files accordingly
PPS. You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Legit |
Hi @epenet as requested i've added more informations on the opening post. |
Please review the remaining two items above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to 0.0.6.1 (link) which relies to websockets 13.0+: that one should be compatible with most of the other libraries here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already requested these twice:
- Please also ensure that you run python -m script.gen_requirements_all to update the requirements files accordingly, as the PR cannot be merged without it
- You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users
Hi @epenet, all steps requested are done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ElmaxSrl 👍
../Frenck
Co-authored-by: Alberto Geniola <[email protected]>
Proposed change
Update elmax_api to v0.0.6.1
albertogeniola/elmax-api@v0.0.5...v0.0.6.1
This PR fixes #131216
Type of change
Additional information
albertogeniola/elmax-api@v0.0.5...v0.0.6.1
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: