Add initial support for SwitchBot relay switch #130863
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
bot
added
cla-needed
has-tests
integration: switchbot
new-feature
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
Quality Scale: No score
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| raise AbortFlow( | ||
| "api_error", description_placeholders={"error_detail": str(ex)} | ||
| ) from ex |
There was a problem hiding this comment.
I think you can use return self.async_abort( instead here
There was a problem hiding this comment.
Thanks，already changed to return self.async_abort(
There was a problem hiding this comment.
Thank you for your feedback. I have made the requested changes and addressed the issues. Please review again.
| @@ -39,5 +39,5 @@ | |||
| "documentation": "https://www.home-assistant.io/integrations/switchbot", | |||
| "iot_class": "local_push", | |||
| "loggers": ["switchbot"], | |||
| "requirements": ["PySwitchbot==0.51.0"] | |||
| "requirements": ["PySwitchbot==0.53.0"] | |||
There was a problem hiding this comment.
Please bump the dependency in a preliminary PR
There was a problem hiding this comment.
I have added a link to the changelog in the PR description.
There was a problem hiding this comment.
But can you please open a prelimary PR where we bump the version? Check point 7 at https://developers.home-assistant.io/docs/review-process#creating-the-perfect-pr for the explanation behind it :)
There was a problem hiding this comment.
Sorry, I opened a prelimary PR here. #130869
There was a problem hiding this comment.
Thank you for your feedback. I have made the requested changes and addressed the issues. Please review again.
…into feature/relay-switch
Breaking change
Proposed change
This pull request is from the in-house dev team at SwitchBot. Two new models of relay switches are added, SwitchBot Relay Switch 1 and Relay Switch 1PM. The
PySwitchbotdependency has been updated, mainly adding support Relay Switch 1 and Relay Switch 1PM, see https://github.com/Danielhiversen/pySwitchbot/releases/tag/0.52.0Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: