Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device handling for disconnected IronOS devices #130787

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Nov 16, 2024

Proposed change

  • A Devices' config entry is now set up normally without raising ConfigEntryNotReady even if it is not connected, and its state is shown as unavailable since this device type is mostly disconnected.
  • Update entity will now restore the last known installed version from entity store.
  • Firmware version and serial number in device info get updated now in coordinator if device was not connected on entry setup or if the fw version has changed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@balloob
Copy link
Member

balloob commented Nov 17, 2024

As limitation of these changes, the DeviceInfo will now lack the serial number, ID, and firmware version, if the device was not connected during config entry setup.

Maybe we can fetch this data when device is discovered, so we can do the setup without having it connected?

@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Nov 17, 2024

As limitation of these changes, the DeviceInfo will now lack the serial number, ID, and firmware version, if the device was not connected during config entry setup.

Maybe we can fetch this data when device is discovered, so we can do the setup without having it connected?

@balloob I think I found a viable solution. As the firmware version may eventually change i decided to let the coordinator save this information in the config entry.

homeassistant/components/iron_os/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/iron_os/entity.py Outdated Show resolved Hide resolved
homeassistant/components/iron_os/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 18, 2024 10:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@tr4nt0r tr4nt0r marked this pull request as ready for review November 18, 2024 12:48
@home-assistant home-assistant bot requested a review from joostlek November 18, 2024 12:48
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 25, 2024
@tr4nt0r tr4nt0r force-pushed the iron_os_no_updatefailed branch from 93f5743 to b73f397 Compare November 30, 2024 22:08
@tr4nt0r tr4nt0r force-pushed the iron_os_no_updatefailed branch from b73f397 to 814689c Compare December 14, 2024 12:09
@tr4nt0r tr4nt0r force-pushed the iron_os_no_updatefailed branch from 814689c to c8b237e Compare December 17, 2024 22:07
tests/components/iron_os/test_update.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft December 18, 2024 09:42
@tr4nt0r tr4nt0r marked this pull request as ready for review December 19, 2024 01:00
@home-assistant home-assistant bot requested a review from joostlek December 19, 2024 01:00
@tr4nt0r tr4nt0r marked this pull request as draft December 19, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by-code-owner cla-signed code-quality integration: iron_os Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants