-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve device handling for disconnected IronOS devices #130787
base: dev
Are you sure you want to change the base?
Conversation
Maybe we can fetch this data when device is discovered, so we can do the setup without having it connected? |
@balloob I think I found a viable solution. As the firmware version may eventually change i decided to let the coordinator save this information in the config entry. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
93f5743
to
b73f397
Compare
b73f397
to
814689c
Compare
814689c
to
c8b237e
Compare
Proposed change
ConfigEntryNotReady
even if it is not connected, and its state is shown asunavailable
since this device type is mostly disconnected.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: