-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ezviz battery camera work mode #130478
base: dev
Are you sure you want to change the base?
Ezviz battery camera work mode #130478
Conversation
Hey there @RenierM26, @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
FYI @pjbuffard I moved your branch to my fork as I did not have push permissions and PR got closed |
is this codecov step a new thing? i don't remember this one on the old PR, also it complains about test coverage being basically zero meaning that there were no prior tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is doing multiple things, and therefore, this PR should be split.
Split this PR into two PRs, where one is bumping the library only and the second is adding the new select entity. Please keep the second one in draft until the first one is merged.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…rescio/core into ezviz-battery-camera-work-mode
due to a bug in the latest library version the bump had to be rolledback with: this PR must wait till see issue: |
Hi @srescio, I created a new repository and renamed the library. (Original developer is no longer reachable. So thought it's easier to keep the name consistent with pypi package etc.) Left a note on the in the pyezviz github readme to the new location. Other than that, you could look at the SupportExt constant to only add when cameras support this function. It's most likely "SupportBatteryManage" |
Hi @srescio, I think it's a bit cleaner to add the methods to the entity_description dictionary. Also adds the ability to use supported features from the api for entities. Please have a look at this example: It's just a suggestion that might make it easier for additional select entities in the future. |
Proposed change
Add a new select entity called "Battery work mode". Allows setting and getting camera work mode for battery powered camera.
original PR by @pjbuffard
#105802
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: