Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ring-doorbell to 0.9.12 #130419

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Bump ring-doorbell to 0.9.12 #130419

merged 4 commits into from
Nov 13, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Nov 12, 2024

Proposed change

Bump ring-doorbell library to 0.9.12

  • Fixes an issue with the Ring Elite motion and ring events. Would be good to get into 2024.11.2
  • Add is_update to ring events to allow duplicates to be filtered out in a subsequent PR.

Fixes #128180

Related to #128332

0.9.12 release notes
python-ring-doorbell/python-ring-doorbell@0.9.9...0.9.12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Nov 12, 2024

I did a quick scan of the dependency bump, and I noticed the changed path for from websockets.asyncio.client import ClientConnection
This is only compatible from websockets v13.0, so you should really adjust the requirement in your pyproject.toml

Side note, HA enforces a minimum for websockets (>=11.0.1) but no maximum

# websockets 11.0 is missing files in the source distribution
# which break wheel builds so we need at least 11.0.1
# https://github.com/aaugustin/websockets/issues/1329
websockets>=11.0.1

@sdb9696 sdb9696 marked this pull request as draft November 12, 2024 12:41
@sdb9696
Copy link
Contributor Author

sdb9696 commented Nov 12, 2024

Many thanks for the pointer there @epenet . I'm going to yank the 0.9.10 release and update this PR with a new release.

@sdb9696 sdb9696 changed the title Bump ring-doorbell to 0.9.10 Bump ring-doorbell to 0.9.12 Nov 12, 2024
@sdb9696 sdb9696 marked this pull request as ready for review November 12, 2024 13:12
@sdb9696
Copy link
Contributor Author

sdb9696 commented Nov 12, 2024

So I've yanked 0.9.10 and 0.9.11.

0.9.11 had a change to fix another issue that won't effect HA at the moment until I submit another PR on the HA side.

@bdraco bdraco merged commit ac4cb52 into home-assistant:dev Nov 13, 2024
65 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@sdb9696 sdb9696 deleted the ring/bump_lib branch November 15, 2024 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ring Doorbell Elite Motion Entity missing
4 participants