Improve nest camera stream expiration to be defensive against errors #130265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Harden nest stream expiration by adding backoff and ensuring that failures are handled defensively to avoid immediately retrying. This also adds a defense against a bad clock that could result in an immediate retry by setting a minimum interval.
The retry logic is extracted to a helper class, and now each WebRTC stream has its own alarm rather than a single alarm that refreshes all streams. This is needed to make the logic for managing backoff or the min refresh interval simpler since it only has to consider one stream at a time.
Adds a test that exercises a case where a refreshed stream expires in the past and ensuring it waits a minimum refresh period before extending the stream.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: