-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go2rtc workaround for HA managed one until upstream fixes it #130139
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@carloda This is a PR; if you want to discuss or report an issue, the issue you linked is a more appropriate place. Please note that pinging people might come across as demanding attention; while you probably mean well, we do discourage it. Thanks for understanding 👍 ../Frenck |
I apologize, my intention was to bring to light an issue and if it was related to the discussion to close it, I apologize again. :/ |
No worries 👍 |
Breaking change
Proposed change
Currently, there exists a go2rtc endless loop with the config we use it.
The problem is the following line:
f"ffmpeg:{camera.entity_id}#audio=opus"
. By specifying the go2rtc name, go2rtc calls the ffmpeg in an endless loop as it is using itself as a source for the stream, which, of course, will not work.Until the problem is fixed upstream, I have added with this PR a workaround for the go2rtc instance managed by HA.
It's not possible to add this workaround for self-hosted instances, as we would need to know the port where the internal RTSP server is running. This is not straightforward, as the port can be changed with the config. Getting the config and parsing it is out of the scope of this bug fix.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: