Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force int value on port in P1Monitor #130084

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

klaasnicolaas
Copy link
Member

Proposed change

Force int value for port

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@klaasnicolaas klaasnicolaas marked this pull request as draft November 7, 2024 20:42
@klaasnicolaas klaasnicolaas marked this pull request as ready for review November 8, 2024 07:57
@klaasnicolaas
Copy link
Member Author

Followed the change from: #130104, merge that PR before this one.

./Klaas

@epenet epenet added this to the 2024.11.1 milestone Nov 8, 2024
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet changed the title Force int value on port - P1Monitor Force int value on port in P1Monitor Nov 8, 2024
@epenet
Copy link
Contributor

epenet commented Nov 8, 2024

Small thing to improve the PR: you could adjust the tests.

assert result2.get("type") is FlowResultType.CREATE_ENTRY
assert result2.get("title") == "P1 Monitor"
assert result2.get("data") == {CONF_HOST: "example.com", CONF_PORT: 80}
assert len(mock_setup_entry.mock_calls) == 1
assert len(mock_p1monitor.mock_calls) == 1

Adding isinstance check fails on dev, and works on your branch...

    assert result2.get("type") is FlowResultType.CREATE_ENTRY
    assert result2.get("title") == "P1 Monitor"
    assert result2.get("data") == {CONF_HOST: "example.com", CONF_PORT: 80}
    assert isinstance(result2["data"][CONF_PORT], int)

    assert len(mock_setup_entry.mock_calls) == 1
    assert len(mock_p1monitor.mock_calls) == 1

@frenck frenck merged commit 2dc81ed into home-assistant:dev Nov 8, 2024
32 checks passed
frenck pushed a commit that referenced this pull request Nov 8, 2024
@frenck frenck mentioned this pull request Nov 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1Mon cannot be added
3 participants