Fix KeyError in nest integration when the old key format does not exist
#130057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: nest
small-pr
19 tasks
joostlek
reviewed
Nov 7, 2024
homeassistant/components/nest/api.py
Outdated
| CONF_SUBSCRIPTION_NAME, entry.data.get(CONF_SUBSCRIBER_ID) | ||
| ) | ||
| ): | ||
| raise ValueError( |
There was a problem hiding this comment.
What happens when this is raised? How can the user recover from this?
There was a problem hiding this comment.
This is a shouldn't happen / bug. Let me try one more simpler way...
joostlek
reviewed
Nov 7, 2024
joostlek
approved these changes
Nov 7, 2024
Co-authored-by: Joost Lekkerkerker <[email protected]>
This was referenced Nov 8, 2024
frenck
pushed a commit
that referenced
this pull request
Nov 8, 2024
…xist (#130057) * Fix bug in nest setup when the old key format does not exist * Further simplify the entry.data check * Update homeassistant/components/nest/api.py Co-authored-by: Joost Lekkerkerker <[email protected]> --------- Co-authored-by: Joost Lekkerkerker <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix bug in nest setup when the old key format does not exist causing a
KeyError. This was a change made during PR to simplify code but I missed test coverage for this case.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: