-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate go2rtc server version #129810
Validate go2rtc server version #129810
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
_LOGGER.warning("The go2rtc server version is not supported, %s", err) | ||
return False | ||
raise ConfigEntryNotReady( | ||
f"The go2rtc server version is not supported, {err}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the error explain what version is required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's explained. It's not very visible though since it's logged at debug level from homeassistant.config_entries
:
2024-11-05 11:06:27.513 DEBUG (MainThread) [homeassistant.config_entries] Config entry 'go2rtc' for go2rtc integration not ready yet: The go2rtc server version is not supported, server version '1.9.4' not >= 1.9.5 and < 2.0.0; Retrying in 5 seconds
Proposed change
Validate go2rtc server version
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: