Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate go2rtc server version #129810

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Validate go2rtc server version #129810

merged 2 commits into from
Nov 5, 2024

Conversation

emontnemery
Copy link
Contributor

Proposed change

Validate go2rtc server version

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery added this to the 2024.11.0 milestone Nov 4, 2024
@emontnemery emontnemery requested a review from a team as a code owner November 4, 2024 14:02
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (go2rtc) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of go2rtc can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign go2rtc Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare marked this pull request as draft November 4, 2024 16:38
@emontnemery emontnemery marked this pull request as ready for review November 5, 2024 09:17
_LOGGER.warning("The go2rtc server version is not supported, %s", err)
return False
raise ConfigEntryNotReady(
f"The go2rtc server version is not supported, {err}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the error explain what version is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's explained. It's not very visible though since it's logged at debug level from homeassistant.config_entries:

2024-11-05 11:06:27.513 DEBUG (MainThread) [homeassistant.config_entries] Config entry 'go2rtc' for go2rtc integration not ready yet: The go2rtc server version is not supported, server version '1.9.4' not >= 1.9.5 and < 2.0.0; Retrying in 5 seconds

@frenck frenck merged commit 8889464 into dev Nov 5, 2024
32 checks passed
@frenck frenck deleted the go2rtc_check_version branch November 5, 2024 10:09
frenck pushed a commit that referenced this pull request Nov 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants