Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yt-dlp to 2024.11.04 #129794

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Bump yt-dlp to 2024.11.04 #129794

merged 1 commit into from
Nov 4, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Nov 4, 2024

Proposed change

Bump yt-dlp to 2024.11.04
https://github.com/yt-dlp/yt-dlp/releases/tag/2024.11.04

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

@frenck frenck merged commit 0c40fcd into home-assistant:dev Nov 4, 2024
41 of 42 checks passed
balloob pushed a commit that referenced this pull request Nov 4, 2024
@seproDev
Copy link

seproDev commented Nov 5, 2024

Hey, yt-dlp maintainer here. With this release, we changed how dependencies are handled. Previously, yt-dlp would install all recommended dependencies, while now they are only included with the default extra group (i.e. yt-dlp[default]). This allows for easy inclusion of just yt-dlp without any dependencies. Unless you have a reason not to include these dependencies, I would still recommend including them.

Release notes: https://github.com/yt-dlp/yt-dlp/releases/tag/2024.11.04
More details: yt-dlp/yt-dlp#11255

@joostlek joostlek deleted the ytdlp-1104 branch November 5, 2024 10:33
@joostlek
Copy link
Member Author

joostlek commented Nov 5, 2024

I did see that in the notes, but I thought we already depended on the dependencies (and hence it would not be needed) but if you recommend it we can still include that

@joostlek joostlek mentioned this pull request Nov 5, 2024
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants