Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to av 13.1.0 #129699

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 2, 2024

Proposed change

https://pyav.basswood-io.com/docs/stable/development/changelog.html?highlight=changelog#v13-1-0
Wheels are up on: https://wheels.home-assistant.io/musllinux/

As best as I can tell we switched from av to ha-av when the development upstream stalled. The diff suggests that the missing feature was bitstream filters PyAV-Org/PyAV@main...uvjustin:PyAV:main. Since then upstream development has resumed and support for bitstream filters was added in 12.1.0.

Important

Although all CI tests pass, it would be great if this change could be tested on a production instance before merging.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2024

Hey there @davet2001, mind taking a look at this pull request as it has been labeled with an integration (generic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of generic can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign generic Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 2, 2024

Hey there @hunterjm, @uvjustin, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stream can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stream Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p cdce8p requested a review from bdraco November 2, 2024 21:29
@bdraco
Copy link
Member

bdraco commented Nov 2, 2024

I updated my primary production with this. Nothing obvious broke with cameras

@bdraco
Copy link
Member

bdraco commented Nov 2, 2024

Updated secondary production as well. All good

@cdce8p
Copy link
Member Author

cdce8p commented Nov 2, 2024

I updated my primary production with this. Nothing obvious broke with cameras

Awesome, thanks for testing! Will leave this open a while longer to give others the opportunity to test as well. I explicitly did the unrelated changes first so if something unexpected should break during the beta next month, it should be as simple as reverting just this PR.

@bdraco
Copy link
Member

bdraco commented Nov 2, 2024

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/setup.py", line 420, in _async_setup_component
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/stream/__init__.py", line 226, in async_setup
    await hass.async_add_executor_job(set_pyav_logging, debug_enabled)
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/stream/__init__.py", line 196, in set_pyav_logging
    import av  # pylint: disable=import-outside-toplevel
    ^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/av/__init__.py", line 17, in <module>
    from av.bitstream import BitStreamFilterContext, bitstream_filters_available
  File "/usr/local/lib/python3.12/site-packages/av/bitstream/__init__.py", line 1, in <module>
    from .context import BitStreamFilterContext
  File "av/bitstream/context.pyx", line 1, in init av.bitstream.context
ValueError: av.frame.Frame size changed, may indicate binary incompatibility. Expected 56 from C header, got 48 from PyObject

Got this on another system.

@bdraco
Copy link
Member

bdraco commented Nov 2, 2024

nevermind, testing error, forgot to uninstall ha-av first on that one

@bdraco
Copy link
Member

bdraco commented Nov 2, 2024

All good once I uninstalled ha-av and reinstalled av on the 3rd system 👍

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit 41a81cb into home-assistant:dev Nov 4, 2024
45 of 46 checks passed
@cdce8p cdce8p deleted the switch-to-av-13.1.0 branch November 4, 2024 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants