Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert "LLM Tool parameters check (#123621)" #129064

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

tronikos
Copy link
Member

Breaking change

Proposed change

Partially revert commit a85ccb9 that caused a regression.
Kept the original changes in tests since these are fine.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tronikos tronikos added this to the 2024.10.4 milestone Oct 24, 2024
@tronikos tronikos requested a review from a team as a code owner October 24, 2024 06:50
@Shulyaka
Copy link
Contributor

LGTM as a hotfix.
I think that parameter validation should be the responsibility of the helper, not the tool itself. But currently we only have tools for intents and scripts, and they all do their own validation.

@joostlek joostlek merged commit 267e1dd into home-assistant:dev Oct 25, 2024
46 checks passed
@frenck frenck mentioned this pull request Oct 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
@tronikos tronikos deleted the llm_params branch December 29, 2024 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HassLightSet color parameter from Google Generative AI
4 participants