Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to Comelit SimpleHome #128794

Merged

Conversation

chemelli74
Copy link
Contributor

Breaking change

Proposed change

Add diagnostics to Comelit SimpleHome

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 marked this pull request as ready for review October 19, 2024 19:26
@chemelli74 chemelli74 requested a review from joostlek October 19, 2024 19:27
@chemelli74 chemelli74 added this to the 2024.10.4 milestone Oct 20, 2024
epenet
epenet previously requested changes Oct 21, 2024
tests/components/comelit/test_diagnostics.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 21, 2024 09:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@chemelli74 chemelli74 marked this pull request as ready for review October 21, 2024 15:55
@home-assistant home-assistant bot requested a review from epenet October 21, 2024 15:55
@joostlek
Copy link
Member

You can exclude those keys in the snapshot

@chemelli74 chemelli74 merged commit e08e864 into home-assistant:dev Oct 21, 2024
32 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-diagnostics branch October 21, 2024 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants