Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle temprorary hold in Honeywell #128460

Merged
merged 11 commits into from
Oct 24, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Oct 15, 2024

Proposed change

Add temporary hold conditions to properly set HA system mode.
Use constants to eliminate a few "magic" numbers in hold code.
Add tests to verify hold conditions are set correctly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/honeywell/climate.py Outdated Show resolved Hide resolved
tests/components/honeywell/test_climate.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 24, 2024 17:26
@mkmer mkmer marked this pull request as ready for review October 24, 2024 18:04
@home-assistant home-assistant bot requested a review from joostlek October 24, 2024 18:04
@joostlek joostlek merged commit fe1d8b1 into home-assistant:dev Oct 24, 2024
32 checks passed
@joostlek joostlek added this to the 2024.10.4 milestone Oct 24, 2024
@mkmer mkmer deleted the Honeywell-handle-temprorary-hold branch October 24, 2024 18:09
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Oct 25, 2024
frenck pushed a commit that referenced this pull request Oct 25, 2024
@frenck frenck mentioned this pull request Oct 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Not Properly Handling Holds
3 participants