Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align consumption sensor names in ViCare integration #127888

Merged
merged 11 commits into from
Oct 20, 2024
Merged

Align consumption sensor names in ViCare integration #127888

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
faa9010
update sensor labels
CFenner Oct 7, 2024
3ced350
revert changes to gas entity description
CFenner Oct 8, 2024
634bab2
use electricity instead of power and energy
CFenner Oct 8, 2024
c1ea7f9
revern reuse
CFenner Oct 8, 2024
378f40f
Revert "use electricity instead of power and energy"
CFenner Oct 8, 2024
4fca2de
rename :tada:
CFenner Oct 8, 2024
07d0b56
update
CFenner Oct 11, 2024
5e5e39a
update
CFenner Oct 11, 2024
4dfa954
update
CFenner Oct 11, 2024
4961a92
update
CFenner Oct 11, 2024
4ebcd72
update
CFenner Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions homeassistant/components/vicare/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,28 +234,40 @@
"name": "DHW gas consumption last seven days"
},
"energy_summary_consumption_heating_currentday": {
"name": "Heating energy consumption today"
"name": "Electrical energy consumption for heating today"
},
"energy_summary_consumption_heating_currentmonth": {
"name": "Heating energy consumption this month"
"name": "Electrical energy consumption for heating this month"
},
"energy_summary_consumption_heating_currentyear": {
"name": "Heating energy consumption this year"
"name": "Electrical energy consumption for heating this year"
},
"energy_summary_consumption_heating_lastsevendays": {
"name": "Heating energy consumption last seven days"
"name": "Electrical energy consumption for heating last seven days"
},
"energy_dhw_summary_consumption_heating_currentday": {
"name": "DHW energy consumption today"
"name": "Electrical energy consumption for DHW today"
},
"energy_dhw_summary_consumption_heating_currentmonth": {
"name": "DHW energy consumption this month"
"name": "Electrical energy consumption for DHW this month"
},
"energy_dhw_summary_consumption_heating_currentyear": {
"name": "DHW energy consumption this year"
"name": "Electrical energy consumption for DHW this year"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I saw that there was a whole discussion (I did not read, sorry for that), but let me ask a quick question, would it make sense to keep the start of the name contain the type? Because if I imagine a device with these entities, on the device page everything looks like Electrical energy consum.... And if I translate it to Dutch Energie consumptie .... (I am not sure how wide it will show, but with this long name, I can see it being cut off, that's my point).

Would it make sense to have Heating electrical energy consumption today? (under the assumption the reason this PR exists is because of the added emphasis on eletrical).

(I think usually I wouldn't make this big of a deal of this, but in this case it can be 12(?) entities, so that would most likely lead to people renaming the things).

(Also, added question, on what level is this information collected? Would it make sense to only show the heating usage on the heating device and DHW on the DHW device?)

},
"energy_summary_dhw_consumption_heating_lastsevendays": {
"name": "DHW energy consumption last seven days"
"name": "Electrical energy consumption for DHW last seven days"
},
"power_consumption_today": {
"name": "Electrical energy consumption today"
},
"power_consumption_this_week": {
"name": "Electrical energy consumption this week"
},
"power_consumption_this_month": {
"name": "Electrical energy consumption this month"
},
"power_consumption_this_year": {
"name": "Electrical energy consumption this year"
},
"power_production_current": {
"name": "Power production current"
Expand Down Expand Up @@ -290,18 +302,6 @@
"solar_power_production_this_year": {
"name": "Solar energy production this year"
},
"power_consumption_today": {
"name": "Energy consumption today"
},
"power_consumption_this_week": {
"name": "Power consumption this week"
},
"power_consumption_this_month": {
"name": "Energy consumption this month"
},
"power_consumption_this_year": {
"name": "Energy consumption this year"
},
"buffer_top_temperature": {
"name": "Buffer top temperature"
},
Expand Down
Loading