Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aiohttp to 3.10.9 #127594

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Bump aiohttp to 3.10.9 #127594

merged 1 commit into from
Oct 5, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 4, 2024 •
edited
Loading

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.10.9

changelog: aio-libs/aiohttp@v3.10.8...v3.10.9

This is a technically breaking change, the default connect timeout is now 30s to fix a bug where the next ip would not be tried within the default timeout period of 150s since it would never move on to the next ip otherwise. I expect this will not be a problem but I wanted to point it out.

There is also a fix relevant to HA's default connector aio-libs/aiohttp#9368 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco
Bump aiohttp to 3.10.9
55ff6a1 
https://github.com/aio-libs/aiohttp/releases/tag/v3.10.9

changelog: aio-libs/aiohttp@v3.10.8...v3.10.9

This is a technically breaking change, the default connect timeout is now 30s to
fix a bug where the next ip would not be tried within the default timeout
period of 150s. I expect this will not be a problem but I wanted to
point it out.
@bdraco bdraco marked this pull request as ready for review October 4, 2024 18:56
@bdraco bdraco requested a review from a team as a code owner October 4, 2024 18:56
@MartinHjelmare MartinHjelmare merged commit 58d0dbb into dev Oct 5, 2024
59 of 67 checks passed
@MartinHjelmare MartinHjelmare deleted the aiohttp3109 branch October 5, 2024 05:48
@bdraco
Copy link
Member Author

bdraco commented Oct 5, 2024

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed core dependency Hacktoberfest small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @MartinHjelmare