Add mmol support to nightscout

[danielwindit]

Breaking change

Proposed change

This PR adds mmol/l support to the existing Nightscout integration. Mmol/l is mostly used in Europe for glucose readings.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @danielwindit

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hey there @marciogranzotto, mind taking a look at this pull request as it has been labeled with an integration (nightscout) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nightscout can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign nightscout Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Stale

[epenet]

Please add the unit constants to const.py

[epenet]

Version is required for local testing as s custom component
It is forbidden on core

[danielwindit]

Version is required for local testing as s custom component It is forbidden on core

Ok, I removed it again. The hassfest test was complaining about it. Sorry for all the commits, this is the first time I contribute.

[epenet]

@danielwindit thanks for your contribution thus far.
However, discussing some more with @joostlek we are unsure if this should be part of the config_flow.

Maybe it should simply be handled outside of the integration, using a Template instead.
Is there a reason that you are not using a Template entity?

[danielwindit]

@danielwindit thanks for your contribution thus far. However, discussing some more with @joostlek we are unsure if this should be part of the config_flow.

Maybe it should simply be handled outside of the integration, using a Template instead. Is there a reason that you are not using a Template entity?

@epenet that's what I have been using before but I couldn't get the arrow working showing which shows the delta direction. mmol/L is the most common measurement used in the UK with mg/dL predominantly used in the USA and continental Europe, that given I figured more would benefit this addition.

[frenck]

This is a duplicate of #58921, #54898, and #41382 (all closed)

We concluded this should not be part of an option flow, as that would break statistics, config flow seemed to be the better option at the time (which is in this PR).

#58921 (comment)

However; nowadays we added reconfiguration for config flows as well (which will be part of the next quality scale iteration requirements). Therefore, IMHO, both are bad options.

I think at this point there are 2 possible solutions:

• Expose 2 sensors (also not really nice)
• HA support unit conversations nowadays, in which the user can decide the unit to show. We could explore the ability to add a unit of measurement for this with both units.

[epenet]

I have opened an arch discussion for this: home-assistant/architecture#1146

[frenck]

Replaced by #129340

With that, a user can now just select the unit they prefer on the sensor level.

../Frenck