Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecobee test helper #126587

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix ecobee test helper #126587

merged 1 commit into from
Sep 24, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Sep 24, 2024

Proposed change

Fix ecobee test helper setup_platform:

  • Correct patch of homeassistant.components.ecobee.const.PLATFORMS
  • Use hass.config_entries.async_setup to set up the ecobee config entry

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck merged commit ce70f4e into dev Sep 24, 2024
31 checks passed
@frenck frenck deleted the ecobee_fix_test_helper branch September 24, 2024 06:30
myztillx added a commit to myztillx/home-assistant-core that referenced this pull request Sep 24, 2024
myztillx added a commit to myztillx/home-assistant-core that referenced this pull request Sep 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants