-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new JVC Projector auth method #126453
Conversation
Hey there @msavazzi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy is failing
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Odd. Not sure how it let me commit with the local pre-commit mypy check in place. Should be fixed now though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @SteveEasley 👍
../Frenck
Breaking change
Proposed change
Owners of newer JVC Projector's can't use the integration because JVC has changed the protocol and now requires a SHA256 encoded password for all network communications. Support for this was added into the dependent library.
SteveEasley/pyjvcprojector@05d8e86
https://pypi.org/project/pyjvcprojector/#history
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: