Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden scope of ConfigEntryNotReady in Mealie #126208

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Broaden scope of ConfigEntryNotReady in Mealie #126208

merged 1 commit into from
Sep 18, 2024

Conversation

andrew-codechimp
Copy link
Contributor

Proposed change

When running Mealie behind an nginx proxy, if Mealie is not started when starting Home Assistant a 502 html page is returned, resulting in a MealieError rather than a MealieConnectionError.
Broadening the scope of raising ConfigEntryNotReady allows for retry and graceful recovery if the Mealie application is slow to come up after a system restart.

Error setting up entry Mealie for mealie
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 604, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/mealie/__init__.py", line 52, in async_setup_entry
    about = await client.get_about()
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiomealie/mealie.py", line 186, in get_about
    response = await self._get("api/app/about")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiomealie/mealie.py", line 134, in _get
    return await self._request(METH_GET, uri, params=params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/aiomealie/mealie.py", line 125, in _request
    raise MealieError(
aiomealie.exceptions.MealieError: ('Unexpected response from Mealie', {'Content-Type': 'text/html', 'response': '<html>\r\n<head><title>502 Bad Gateway</title></head>\r\n<body>\r\n<center><h1>502 Bad Gateway</h1></center>\r\n<hr><center>openresty</center>\r\n</body>\r\n</html>\r\n'})

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (mealie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mealie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mealie Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@joostlek joostlek added this to the 2024.9.3 milestone Sep 18, 2024
@joostlek joostlek merged commit adf25b4 into home-assistant:dev Sep 18, 2024
31 checks passed
@andrew-codechimp andrew-codechimp deleted the mealie-config-entry-not-ready branch September 18, 2024 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees

@joostlek joostlek

Labels
bugfix by-code-owner cherry-picked cla-signed integration: mealie Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-codechimp @joostlek @frenck