Add scene support to WMS WebControl pro

[mback2k]

Proposed change

Add scene support to WMS WebControl pro

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add scene support to WMS WebControl pro home-assistant.io#34887

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[joostlek]

Why is every scene its own device?

[mback2k]

It doesn't need to be. Scenes are not a device in the real world, so we could skip this part.

[joostlek]

But I am interested in how they work since they are linked to a room

[mback2k]

On the automatically created dashboard it puts them into the corresponding room:

[mback2k]

It works the same as with other entities which have device information:

[mback2k]

Scenes in WMS are basically the same thing as in HA: "A scene entity is an entity that can reproduce a wanted state for a group of entities. A scene entity can activate the scene towards a group of devices but remains stateless ..."

[joostlek]

Check. Yea I remember that Hue also has scenes, but they are coupled to the group they affect

[mback2k]

Okay, so should I remove or keep the device info?

[mback2k]

I just checked: The following integrations also provide DeviceInfo for Scene implementations:

• fibaro
• hue
• litejet
• lutron_caseta
• tuya

[mback2k]

I did some more research and found out the following:

Fibaro links the scenes to the hub device:

core/homeassistant/components/fibaro/scene.py

Lines 51 to 54 in 8950e81

	# All scenes are shown on hub device
	self._attr_device_info = DeviceInfo(
	identifiers={(DOMAIN, controller.hub_serial)}
	)

Hue actually links the scenes to the room/zone device:

core/homeassistant/components/hue/scene.py

Lines 103 to 107 in 8950e81

	# we create a virtual service/device for Hue zones/rooms
	# so we have a parent for grouped lights and scenes
	self._attr_device_info = DeviceInfo(
	identifiers={(DOMAIN, self.group.id)},
	)

Litejet links the scenes to the hub (mcp?) device:

core/homeassistant/components/litejet/scene.py

Lines 51 to 56 in 8950e81

	self._attr_device_info = DeviceInfo(
	identifiers={(DOMAIN, f"{entry_id}_mcp")},
	name="LiteJet",
	manufacturer="Centralite",
	model=system.model_name,
	)

Lutron Caseta links the scenes to the hub (bridge) device:

core/homeassistant/components/lutron_caseta/scene.py

Lines 41 to 43 in 8950e81

	self._attr_device_info = DeviceInfo(
	identifiers={(CASETA_DOMAIN, data.bridge_device["serial"])},
	)

Only Tuya links the scene to its own (scene_id) device:

core/homeassistant/components/tuya/scene.py

Line 37 in 8950e81

self._attr_unique_id = f"tys{scene.scene_id}"

core/homeassistant/components/tuya/scene.py

Lines 44 to 50 in 8950e81

	return DeviceInfo(
	identifiers={(DOMAIN, f"{self.unique_id}")},
	manufacturer="tuya",
	name=self.scene.name,
	model="Tuya Scene",
	entry_type=DeviceEntryType.SERVICE,
	)

So, we have Hue linking to rooms, 3 others linking to their hub and just Tuya creating per scene devices.

Based on these findings, any suggestion on how to move forward?

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[mback2k]

Thanks a lot! 👍