Use temperature of current preset when set fritz HVAC mode to HEAT #126044
Conversation
home-assistant
bot
added
bugfix
cla-needed
has-tests
integration: fritzbox
small-pr
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Hey there @mib1185, @flabbamann, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
naruxde
force-pushed
the
fritz-hvac-preset-mode
branch
from
4d67742 to
5df75de
Compare
|
Hi @mib1185! I'm really sorry about what always went wrong 😖. I had even, before the push, made a pytest with |
|
Yes, I'm just looking at that. We have with the So we would have to change We then generally only have the problem if eco and comfort are set to the same values in the Fritzbox, which mode should we use in Home Assistant. 🤔 - Currently it would be |
|
I pushed a commit as a suggestion for changing the tests. But maybe you have other ideas 🙂 |
naruxde
force-pushed
the
fritz-hvac-preset-mode
branch
from
ba11dda to
8eb015f
Compare
naruxde
force-pushed
the
fritz-hvac-preset-mode
branch
from
8eb015f to
6992bfb
Compare
naruxde
force-pushed
the
fritz-hvac-preset-mode
branch
from
c6c3d23 to
a428cba
Compare
|
please avoid rebase + force-push. this makes hard to get what has changed since last review, thx 👍 |
|
I just reset the change from the test in the test_set_temperature_mode_heat function. This is also part of PR #126072, if I understand correctly. |
If the HVAC mode of the Fritzbox thermostats changes from `HVACMode.OFF` to `HVAMode.HEAT`, the current preset (COMFORT / ECO) should be observed. Depending on the status of the current preset, the set temperature of comfort / eco is set as the new temperature.
Co-authored-by: Michael <[email protected]>
The current_preset parameter allows the mock to be set to an active preset. When setting HVACMode.HEAT, the respective temperature of the ECO/COMFORT preset should be set.
naruxde
force-pushed
the
fritz-hvac-preset-mode
branch
from
e5422dd to
c5b7a5d
Compare
|
Hi @mib1185! I hope that worked. I removed my tests and extended your new test with a current_preset parameter. I hope that was okay that I didn't insert a new test like before. |
There was a problem hiding this comment.
Hi @naruxde
I thought about it again and unfortunately came to the conclusion, that all the "next change " sensors needs to be fixed. The api returns the comfort temperature as next temperature, when there is no scheduler configured. The only way to detect if a scheduler is configured, is to check the next change time - if it is 0, than there is no scheduler, else it contains a valid future timestamp. I'm already working on a further PR to fix this. Afterwards we should really be able to go ahead with your PR.
thx for your patients 👍
|
Hi @mib1185! Improvements are always good! I would also have no problem with it if you integrate the "hack" from this PR directly into your PR, which maybe results in a better solution. What ever you like most. I look forward to it when the problem described above is solved, gladly also with a better solution than this 😆. |
To distinguish which temperature should be used when setting the `HVAMode.HEAT`, `value_schedules_preset` is now used again, which has been updated since the first commit. If no schedule is active, the comfort_temperature is used. Otherwise, the respective temperature of the current preset. Co-authored-by: Michael <[email protected]>
There was a problem hiding this comment.
don't forget to click on "Ready to review" (#126044 (comment)) 😉
|
Had to test locally 😋 |
…Fritz!Smarthome (home-assistant#126044) * Use temperature of current preset when set fritz HVAC mode to HEAT If the HVAC mode of the Fritzbox thermostats changes from `HVACMode.OFF` to `HVAMode.HEAT`, the current preset (COMFORT / ECO) should be observed. Depending on the status of the current preset, the set temperature of comfort / eco is set as the new temperature. * fixup do not use value_scheduled_preset Co-authored-by: Michael <[email protected]> * Add current_preset value to test_set_hvac_mode The current_preset parameter allows the mock to be set to an active preset. When setting HVACMode.HEAT, the respective temperature of the ECO/COMFORT preset should be set. * fixup Use the updated value_scheduled_preset function To distinguish which temperature should be used when setting the `HVAMode.HEAT`, `value_schedules_preset` is now used again, which has been updated since the first commit. If no schedule is active, the comfort_temperature is used. Otherwise, the respective temperature of the current preset. Co-authored-by: Michael <[email protected]> --------- Co-authored-by: Michael <[email protected]>
Breaking change
Proposed change
I use the FRITZ! DECT 302 thermostats on my heaters. In the Fritz! Box is a heating plan stored, which sets the temperature to COMFORT or ECO at certain times of the day. If I switch off the heating
HVACMode.OFFvia Home Assistant and turn it on again, the COMFORT temperature is always set, although the schedule for ECO is still active.This change is intended to use the ECO temperature when switching on, if the schedule for ECO is still active, otherwise the COMFORT temperature.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: