Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Flipr hub with switch platform #125866

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

cnico
Copy link
Contributor

@cnico cnico commented Sep 12, 2024

Breaking change

None

Proposed change

Addition of flipr hub devices (boxes that act like a relay to start/stop pool pump or lights) with its first platform which is a switch for the state (on, off).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/flipr/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/flipr/entity.py Outdated Show resolved Hide resolved
homeassistant/components/flipr/strings.json Outdated Show resolved Hide resolved
homeassistant/components/flipr/switch.py Outdated Show resolved Hide resolved
homeassistant/components/flipr/switch.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 13, 2024 10:57
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cnico cnico marked this pull request as ready for review September 13, 2024 21:17
@home-assistant home-assistant bot requested a review from joostlek September 13, 2024 21:17
@joostlek joostlek merged commit 2ae4989 into home-assistant:dev Sep 17, 2024
30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants