Add sync clock button for Husqvarna Automower #125689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
reviewed
Sep 10, 2024
slovdahl
approved these changes
Sep 11, 2024
8 tasks
Not until you mentioned it. But it's changed now. |
joostlek
reviewed
Sep 17, 2024
Comment on lines
73
to
80
| entities: list[ButtonEntity] = [] | ||
| entities.extend( | ||
| AutomowerButtonEntity(mower_id, coordinator, description) | ||
| for mower_id in coordinator.data | ||
| if coordinator.data[mower_id].capabilities.can_confirm_error | ||
| for description in BUTTON_TYPES | ||
| if description.exists_fn(coordinator.data[mower_id]) | ||
| ) | ||
| async_add_entities(entities) |
There was a problem hiding this comment.
async_add_entities(
AutomowerButtonEntity(mower_id, coordinator, description)
for mower_id in coordinator.data
for description in BUTTON_TYPES
if description.exists_fn(coordinator.data[mower_id])
)
joostlek
reviewed
Sep 17, 2024
joostlek
reviewed
Sep 17, 2024
joostlek
reviewed
Sep 17, 2024
Co-authored-by: Joost Lekkerkerker <[email protected]>
joostlek
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add a button to set the time of the mower to the current time (if the clock is out of sync). As the mower and the library and the API are not aware of any timezones, we assume, the mower is in the same timezone like set in the frontend. This is already done by some other entities of this integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: