-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle announcement finished for ESPHome TTS response #125625
Handle announcement finished for ESPHome TTS response #125625
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c6eba07
to
e6df092
Compare
e6df092
to
489e48b
Compare
Waiting on a bump to |
489e48b
to
4e68e6e
Compare
Breaking change
Proposed change
Uses the announcement finished callback added in esphome/aioesphomeapi#954
HA has no way of knowing when TTS responses played via the media player are done. ESPHome will send announcement finished messages know for all announcements and TTS, so this is used to trigger the
tts_response_finished
callback in assist satellite.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: