Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle announcement finished for ESPHome TTS response #125625

Merged

Conversation

synesthesiam
Copy link
Contributor

Breaking change

Proposed change

Uses the announcement finished callback added in esphome/aioesphomeapi#954

HA has no way of knowing when TTS responses played via the media player are done. ESPHome will send announcement finished messages know for all announcements and TTS, so this is used to trigger the tts_response_finished callback in assist satellite.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 9, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (assist_satellite) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of assist_satellite can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign assist_satellite Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Sep 9, 2024

Hey there @OttoWinter, @jesserockz, @kbx81, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@synesthesiam synesthesiam marked this pull request as ready for review September 9, 2024 19:18
@home-assistant home-assistant bot marked this pull request as draft September 9, 2024 20:30
@home-assistant
Copy link

home-assistant bot commented Sep 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@synesthesiam synesthesiam force-pushed the synesthesiam-20240909-esphome-handle-announcement-finished branch from c6eba07 to e6df092 Compare September 10, 2024 17:25
@balloob balloob changed the title Handle announcement finished for TTS response Handle announcement finished for ESPHome TTS response Sep 11, 2024
@synesthesiam synesthesiam force-pushed the synesthesiam-20240909-esphome-handle-announcement-finished branch from e6df092 to 489e48b Compare September 11, 2024 14:12
@synesthesiam
Copy link
Contributor Author

Waiting on a bump to aioesphomeapi

@synesthesiam synesthesiam force-pushed the synesthesiam-20240909-esphome-handle-announcement-finished branch from 489e48b to 4e68e6e Compare September 13, 2024 20:24
@synesthesiam synesthesiam marked this pull request as ready for review September 13, 2024 20:24
@balloob balloob merged commit 3eed5de into dev Sep 13, 2024
30 checks passed
@balloob balloob deleted the synesthesiam-20240909-esphome-handle-announcement-finished branch September 13, 2024 20:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants