Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview to mold_indicator #125530

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add preview to mold_indicator #125530

merged 2 commits into from
Sep 27, 2024

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Add preview to mold_indicator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST marked this pull request as ready for review September 11, 2024 17:52
@frenck frenck added this to the 2024.11.0b0 milestone Sep 26, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 26, 2024
@frenck frenck force-pushed the mold_indicator-preview branch from 9391c2a to d10ac80 Compare September 27, 2024 18:50
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested it locally as well and works as expected.

../Frenck

@frenck frenck merged commit 57e0411 into dev Sep 27, 2024
30 checks passed
@frenck frenck deleted the mold_indicator-preview branch September 27, 2024 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@frenck frenck removed this from the 2024.11.0b0 milestone Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants