Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage settings for enphase_envoy batteries without enpower device #125527

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

catsmanac
Copy link
Contributor

@catsmanac catsmanac commented Sep 8, 2024

Proposed change

When using batteries with the Enphase Envoy, the enphase_envoy integration supports changing battery storage settings charge from grid, Storage mode and Reserve battery level, provided an Enpower device is present in the configuration.

The Enpower device is available when using an Enphase IQ System Controller. This device is not available in many EU countries and in these countries the batteries are installed without it providing no Enpower device.

Changing the actual settings is however done in the Envoy and not in the Enpower device and can be done without the Enpower device being present. The needed entities are currently only created if an Enpower device is present in the configuration.

This PR:

  • Does not change behavior if Enpower device is present, entities remain connected to the Enpower device
  • Will create the needed entities also if batteries are present but no Enpower device is found
    • Connects these entities to the Envoy device in this case
    • Allows changing these setting similar as when connected to the Enpower device
  • Adds a new test fixture with the EU battery configuration
  • Adds new tests and updated snapshot files for this case

Note: This may not work with latest released Enphase Envoy firmware release >= 8.2.42nn as this seems to break with installed Enpower device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 8, 2024

Hey there @bdraco, @cgarwood, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment on lines 133 to 137
sn = (
f"envoy_{mock_envoy.serial_number}"
if use_envoy_serial
else f"enpower_{mock_envoy.data.enpower.serial_number}"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the if statement, so rather just put the serial numbers as parameter.I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the if statement, so rather just put the serial numbers as parameter.I think

These are now removed.

@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 15:23
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@catsmanac catsmanac marked this pull request as ready for review September 10, 2024 18:59
@home-assistant home-assistant bot requested a review from joostlek September 10, 2024 18:59
@ahullah
Copy link

ahullah commented Sep 10, 2024

+1 on this PR, thank you @catsmanac

@catsmanac
Copy link
Contributor Author

+1 on this PR, thank you @catsmanac

Be aware this very well may not work with Envoy firmware 8.2.42nn as that has changed behavior for battery settings. #123216 reports that for 8.2.4286. You have 8.2.4225, so it may work or not.

@joostlek joostlek merged commit 3c1860c into home-assistant:dev Sep 11, 2024
30 checks passed
@catsmanac catsmanac deleted the EnphaseEUBattery branch September 11, 2024 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants