-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage settings for enphase_envoy batteries without enpower device #125527
Conversation
Hey there @bdraco, @cgarwood, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
sn = ( | ||
f"envoy_{mock_envoy.serial_number}" | ||
if use_envoy_serial | ||
else f"enpower_{mock_envoy.data.enpower.serial_number}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the if statement, so rather just put the serial numbers as parameter.I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the if statement, so rather just put the serial numbers as parameter.I think
These are now removed.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
+1 on this PR, thank you @catsmanac |
Be aware this very well may not work with Envoy firmware 8.2.42nn as that has changed behavior for battery settings. #123216 reports that for 8.2.4286. You have 8.2.4225, so it may work or not. |
Proposed change
When using batteries with the Enphase Envoy, the enphase_envoy integration supports changing battery storage settings
charge from grid
,Storage mode
andReserve battery level
, provided an Enpower device is present in the configuration.The Enpower device is available when using an Enphase IQ System Controller. This device is not available in many EU countries and in these countries the batteries are installed without it providing no Enpower device.
Changing the actual settings is however done in the Envoy and not in the Enpower device and can be done without the Enpower device being present. The needed entities are currently only created if an Enpower device is present in the configuration.
This PR:
Note: This may not work with latest released Enphase Envoy firmware release >= 8.2.42nn as this seems to break with installed Enpower device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: