Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated hass.components #125477

Closed
wants to merge 2 commits into from

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Sep 7, 2024

Breaking change

With Home Assistant version 2024.3 we deprecated the usage of hass.components. This has been removed now, custom component should be updated to import the desired components directly.

Proposed change

With version 2024.3 we deprecate the usage of hass.components and scheduled the removal in version 2024.9. Now it is time to remove the deprecated hass.components.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jpbede jpbede requested a review from a team as a code owner September 7, 2024 20:24
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of custom integrations who have not dropped the use of hass.components, including HACS version 1, I think we should consider extending the deprecation period.

@jpbede
Copy link
Member Author

jpbede commented Sep 9, 2024

Sure, sounds reasonable. What do you think would be a good extension? Again 6 months, so we would remove it with 2025.3?

@balloob
Copy link
Member

balloob commented Sep 9, 2024

Yes, let's re-evaluate in 6 months 👍

@balloob balloob closed this Sep 9, 2024
@jpbede
Copy link
Member Author

jpbede commented Sep 9, 2024

Yes, let's re-evaluate in 6 months 👍

Should we do a dev blog post about it?

@bdraco
Copy link
Member

bdraco commented Sep 9, 2024

Yes. Anything we can do to get them to switch would be great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants