Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform sensor to BSBLAN integration #125474

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

liudger
Copy link
Contributor

@liudger liudger commented Sep 7, 2024

Added Sensor platform and tests

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@liudger
Copy link
Contributor Author

liudger commented Sep 7, 2024

I need to rebase this on dev before reviewing. Now based on branch add-tests

@liudger
Copy link
Contributor Author

liudger commented Sep 7, 2024

I have one issue with testing the generated name. Not sure how to mock translation_key is None. @joostlek

@liudger liudger force-pushed the add-platform-sensor branch 2 times, most recently from 7a1fc0b to 58e950f Compare September 8, 2024 18:41
@liudger liudger force-pushed the add-platform-sensor branch from 58e950f to fb2fa0a Compare September 8, 2024 18:42
@liudger liudger marked this pull request as ready for review September 9, 2024 12:16
homeassistant/components/bsblan/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/bsblan/sensor.py Outdated Show resolved Hide resolved
tests/components/bsblan/test_sensor.py Outdated Show resolved Hide resolved
tests/components/bsblan/test_sensor.py Outdated Show resolved Hide resolved
tests/components/bsblan/test_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 15:21
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@liudger liudger marked this pull request as ready for review September 12, 2024 07:32
@home-assistant home-assistant bot requested a review from joostlek September 12, 2024 07:32
@joostlek joostlek merged commit 1ae1391 into home-assistant:dev Sep 13, 2024
29 checks passed
@liudger liudger deleted the add-platform-sensor branch September 13, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants