-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep ZHA entity enabled setting in sync with lib #125472
Keep ZHA entity enabled setting in sync with lib #125472
Conversation
Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b6ea2bb
to
697c6b0
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
25742d5
to
448c5f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also wondering if we should add tests for this to make sure this works like expected and doesn't get regressions from the entity registry or library, WDYT?
another good call... caught an issue w/ a key change that was made in the lib after this was originally written 🤦🏻 |
Haha, I was doubting if I wanted to be more annoying or if this was enough for me to merge, glad I did mention it :) |
25ca7bb
to
4bed7c3
Compare
Proposed change
This PR ensures that the ZHA lib and HA enabled setting are in sync.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: