Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep ZHA entity enabled setting in sync with lib #125472

Merged

Conversation

dmulcahey
Copy link
Contributor

Proposed change

This PR ensures that the ZHA lib and HA enabled setting are in sync.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 7, 2024

Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dmulcahey dmulcahey force-pushed the dm/zha-enable-disable-entities branch from b6ea2bb to 697c6b0 Compare September 22, 2024 12:09
@dmulcahey dmulcahey marked this pull request as ready for review October 1, 2024 13:38
homeassistant/components/zha/helpers.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 2, 2024 17:58
@home-assistant
Copy link

home-assistant bot commented Oct 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dmulcahey dmulcahey force-pushed the dm/zha-enable-disable-entities branch from 25742d5 to 448c5f3 Compare October 3, 2024 12:05
@dmulcahey dmulcahey marked this pull request as ready for review October 3, 2024 12:32
@home-assistant home-assistant bot requested a review from joostlek October 3, 2024 12:32
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also wondering if we should add tests for this to make sure this works like expected and doesn't get regressions from the entity registry or library, WDYT?

@dmulcahey
Copy link
Contributor Author

I am also wondering if we should add tests for this to make sure this works like expected and doesn't get regressions from the entity registry or library, WDYT?

another good call... caught an issue w/ a key change that was made in the lib after this was originally written 🤦🏻

@joostlek
Copy link
Member

joostlek commented Oct 3, 2024

Haha, I was doubting if I wanted to be more annoying or if this was enough for me to merge, glad I did mention it :)

@dmulcahey dmulcahey force-pushed the dm/zha-enable-disable-entities branch from 25ca7bb to 4bed7c3 Compare October 16, 2024 15:52
@dmulcahey dmulcahey merged commit 065577c into home-assistant:dev Oct 17, 2024
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants