Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smlight discovery hostname as device name #125359

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

thecode
Copy link
Member

@thecode thecode commented Sep 5, 2024

Proposed change

Currently the device model is used as device name while the device has an option to set the hostname of the device. Using the device model is confusing since you can have multiple devices with the same model on the same network.

This change uses the discovery hostname as device name, for manual added devices the device model is still used as a fallback but in the future this can be improved by retrieving the hostname from the device for manually added devices using the /ha_info endpoint.

Before:
devices
before

After:
devices-after
after

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 5, 2024

Hey there @tl-sl, mind taking a look at this pull request as it has been labeled with an integration (smlight) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smlight can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smlight Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@tl-sl tl-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally this looks good.

@tl-sl
Copy link
Contributor

tl-sl commented Sep 6, 2024

manually added devices using the /ha_info endpoint.

Currently this endpoint doesn't have hostname field, but will add it in next core firmware release.

@@ -19,7 +19,7 @@
},
"reauth_confirm": {
"title": "[%key:common::config_flow::title::reauth%]",
"description": "Please enter the correct username and password for host: {host}",
"description": "Please enter the correct username and password for {name}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that name (host) is in the title now. lets just drop the host from this string.

"description": "Please enter the correct username and password",

@joostlek joostlek merged commit ff20131 into home-assistant:dev Sep 6, 2024
28 checks passed
@thecode
Copy link
Member Author

thecode commented Sep 6, 2024

Thanks!

@thecode thecode deleted the smlight-hostname branch September 6, 2024 11:03
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Sep 7, 2024
* Use smlight discovery hostname as device name

* Update reauth flow name

* Drop host from description
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants