-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use smlight discovery hostname as device name #125359
Conversation
Hey there @tl-sl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, generally this looks good.
Currently this endpoint doesn't have |
@@ -19,7 +19,7 @@ | |||
}, | |||
"reauth_confirm": { | |||
"title": "[%key:common::config_flow::title::reauth%]", | |||
"description": "Please enter the correct username and password for host: {host}", | |||
"description": "Please enter the correct username and password for {name}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that name (host) is in the title now. lets just drop the host from this string.
"description": "Please enter the correct username and password",
Thanks! |
* Use smlight discovery hostname as device name * Update reauth flow name * Drop host from description
Proposed change
Currently the device model is used as device name while the device has an option to set the hostname of the device. Using the device model is confusing since you can have multiple devices with the same model on the same network.
This change uses the discovery hostname as device name, for manual added devices the device model is still used as a fallback but in the future this can be improved by retrieving the hostname from the device for manually added devices using the
/ha_info
endpoint.Before:
After:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: