Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assist satellite entity component #125351

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Sep 5, 2024

Breaking change

Proposed change

Adds a new integration assist_satellite that implements the first stage of home-assistant/architecture#1114

Future PR's will provide implementations for esphome, voip, and wyoming.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 5, 2024

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (assist_pipeline) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of assist_pipeline can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign assist_pipeline Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@synesthesiam synesthesiam requested a review from a team September 5, 2024 16:37
@synesthesiam synesthesiam marked this pull request as ready for review September 5, 2024 16:37
homeassistant/components/assist_satellite/entity.py Outdated Show resolved Hide resolved
homeassistant/components/assist_satellite/models.py Outdated Show resolved Hide resolved
homeassistant/components/assist_satellite/entity.py Outdated Show resolved Hide resolved
homeassistant/components/assist_satellite/entity.py Outdated Show resolved Hide resolved
homeassistant/components/assist_satellite/manifest.json Outdated Show resolved Hide resolved
script/hassfest/docker/Dockerfile Show resolved Hide resolved
tests/components/assist_satellite/conftest.py Outdated Show resolved Hide resolved
tests/components/assist_satellite/conftest.py Outdated Show resolved Hide resolved
homeassistant/components/assist_satellite/models.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Sep 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 5, 2024 22:01
@balloob balloob marked this pull request as ready for review September 6, 2024 00:55
@balloob balloob merged commit 60b0f0d into dev Sep 6, 2024
38 checks passed
@balloob balloob deleted the synesthesiam-20240905-assist-satellite-entity-component branch September 6, 2024 01:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants