-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor recorder retryable_database_job decorator #125306
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
24a7f09
to
5f3956f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @emontnemery 👍🏻
def _wrap_func_or_meth[**_P]( | ||
job: _FuncOrMethType[_P, bool], description: str, method: bool | ||
) -> _FuncOrMethType[_P, bool]: | ||
recorder_pos = 1 if method else 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recorder_pos = 1 if method else 0 | |
recorder_pos = int(method) |
Not that I'd recommend it, but this would work as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's not an improvement.
Proposed change
Refactor recorder
retryable_database_job
decorator:method
argument for the decoratorThe PR depends on - and currently includes commits from - #125301Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: