Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hadolint to 2.12.0 and use matrix for all Dockerfiles #125131

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

edenhaus
Copy link
Contributor

@edenhaus edenhaus commented Sep 3, 2024

Breaking change

Proposed change

Diff: hadolint/hadolint@v1.18.2...v2.12.0
Use hadolint job with a matrix for all Dockerfiles

FYI: hadolint check for the hassfest docker file will be added in a follow up PR

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@edenhaus edenhaus marked this pull request as ready for review September 3, 2024 10:02
@edenhaus edenhaus requested a review from a team as a code owner September 3, 2024 10:02
@MartinHjelmare MartinHjelmare merged commit d12c6f8 into dev Sep 3, 2024
42 checks passed
@MartinHjelmare MartinHjelmare deleted the edenhaus-hadolint branch September 3, 2024 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants