Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct device serial for ViCare integration #125125

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Sep 3, 2024

Proposed change

This fixes the display of the device serial number, previously showing the gateways serial, now shows the actual heating device serial.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@CFenner CFenner marked this pull request as ready for review September 3, 2024 09:55
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can project the requested changes to the rest of the code :)

homeassistant/components/vicare/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/binary_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 3, 2024 10:08
@home-assistant
Copy link

home-assistant bot commented Sep 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@CFenner CFenner marked this pull request as ready for review September 3, 2024 10:40
@home-assistant home-assistant bot requested a review from joostlek September 3, 2024 10:40
@joostlek joostlek added this to the 2024.9.0 milestone Sep 3, 2024
@joostlek joostlek merged commit f34b449 into home-assistant:dev Sep 3, 2024
26 checks passed
bramkragten pushed a commit that referenced this pull request Sep 3, 2024
* expose correct serial

* adapt inits

* adjust _build_entities

* adapt inits

* add serial data point

* update snapshot

* apply suggestions

* apply suggestions
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants