Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_on function from homeassistant.components #125104

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Sep 2, 2024

Breaking change

The homeassistant.components.is_on function imported is removed now. The removal could break custom intregrations, if they have not been updated yet. The deprecation was reported to annonce that it will break custom integrations that are not updated yet.

Proposed change

Remove is_on function from homeassistant.components

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added breaking-change cla-signed small-pr PRs with less than 30 lines. labels Sep 2, 2024
@jbouwh jbouwh added the ci-full-run Marks a PR to trigger a full CI run (instead of partial) label Sep 2, 2024
@jbouwh jbouwh marked this pull request as ready for review September 2, 2024 20:13
@jbouwh jbouwh requested a review from a team as a code owner September 2, 2024 20:13
@jbouwh jbouwh changed the title Remove is_on method from homeassistant.components Remove is_on function from homeassistant.components Sep 2, 2024
@MartinHjelmare MartinHjelmare merged commit 0c18b2e into dev Sep 3, 2024
40 checks passed
@MartinHjelmare MartinHjelmare deleted the remove-is_on branch September 3, 2024 04:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change ci-full-run Marks a PR to trigger a full CI run (instead of partial) cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants