Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary_sensor platform to LG Thinq #125054

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

LG-ThinQ-Integration
Copy link
Contributor

@LG-ThinQ-Integration LG-ThinQ-Integration commented Sep 2, 2024

Breaking change

Proposed change

Add binary_sensor entity for lg_thinq integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@LG-ThinQ-Integration
Copy link
Contributor Author

LG-ThinQ-Integration commented Sep 2, 2024

Because the document PR for the first code PR is not merged yet, I cannot make a new document PR for this new feature.
I guess the reason why the first document PR is not merged is because that the domain of the integration has been changed.
Let me update the document PR right after the first document PR below is updated

homeassistant/components/lg_thinq/strings.json Outdated Show resolved Hide resolved
homeassistant/components/lg_thinq/strings.json Outdated Show resolved Hide resolved
@joostlek joostlek changed the title Add binary_sensor entity Add binary_sensor platform to LG Thinq Sep 2, 2024
@joostlek
Copy link
Member

joostlek commented Sep 2, 2024

With sentence case I mean -> Remote Start -> Remote start.

@LG-ThinQ-Integration
Copy link
Contributor Author

With sentence case I mean -> Remote Start -> Remote start.

Got it. I updated those.

@LG-ThinQ-Integration
Copy link
Contributor Author

@joostlek
I added the link to the new document PR.

@joostlek
Copy link
Member

joostlek commented Sep 2, 2024

Please mark your review ready if its ready.

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review September 2, 2024 13:47
@LG-ThinQ-Integration
Copy link
Contributor Author

Please mark your review ready if its ready.

Thank you for reminding. I marked it ready.

@LG-ThinQ-Integration
Copy link
Contributor Author

LG-ThinQ-Integration commented Sep 3, 2024

@joostlek
I have a question.
Can I create a PR with 2 platforms(2 entities) in the next platform?

@joostlek
Copy link
Member

joostlek commented Sep 3, 2024

No, but I think we can start opening more (let's not open all yet)

@joostlek joostlek merged commit aa8fe99 into home-assistant:dev Sep 3, 2024
25 of 26 checks passed
@LG-ThinQ-Integration LG-ThinQ-Integration deleted the pr2_binary_sensor branch September 3, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants