Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump py-madvr2 to 1.6.32 #125049

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

iloveicedgreentea
Copy link
Contributor

@iloveicedgreentea iloveicedgreentea commented Sep 2, 2024

Proposed change

This bumps the library version to fix some edge cases and make some improvements

Compare: iloveicedgreentea/py-madvr@1.6.29...1.6.32

  • Add signal info to refresh task. There is an edge case where the aspect ratio data doesnt get updated if the aspect ratio doesnt change in a movie and will lead to stale data
  • Add tests for lib
  • Optimize code for writing and locking
  • Fix potential command sending failure if the connection drops (task was exiting on error)
  • Fix firmware upgrades killing command processing (stop task flag was getting reset on power on, not on connection)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@MartinHjelmare MartinHjelmare marked this pull request as draft September 2, 2024 12:20
@iloveicedgreentea
Copy link
Contributor Author

Added compare view: iloveicedgreentea/py-madvr@1.6.29...1.6.32

@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review September 2, 2024 14:00
@MartinHjelmare MartinHjelmare changed the title Update madVR library for bug fixes Bump py-madvr2 to 1.6.32 Sep 3, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2024.9.0 milestone Sep 3, 2024
@MartinHjelmare MartinHjelmare merged commit 94f458f into home-assistant:dev Sep 3, 2024
40 checks passed
bramkragten pushed a commit that referenced this pull request Sep 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants