Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate entities for temperature, humidity and pressure in AccuWeather integration #125041

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Sep 1, 2024

Breaking change

Proposed change

Users have repeatedly requested separate entities for temperature, humidity, and pressure to eliminate the need to use template sensors and the weather platform entity.
This PR adds these entities as disabled by default. The wind speed and uv index sensors are disabled by default to be consistent, these values are available via the weather entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bieniu
Copy link
Member Author

bieniu commented Sep 2, 2024

Thanks!

@bieniu bieniu merged commit 3206979 into home-assistant:dev Sep 2, 2024
26 checks passed
@bieniu bieniu deleted the accuweather-missing-sensors branch September 2, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature #119013 missing an Entity ID for Humidity data
2 participants