Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiopulse to 0.4.6 #124964

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

atmurray
Copy link
Contributor

@atmurray atmurray commented Aug 31, 2024

Breaking change

Proposed change

Non-breaking changes to fix isses:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Non-breaking changes to fix isses:
 * eliminating hub exceptions raised due use of unicode strings.
 * eliminating hub exceptions raised due to Timers being configured on hub.
@atmurray atmurray changed the title Bump aiopulse to 0.4.6 Acmeda integration bump aiopulse module to 0.4.6 Aug 31, 2024
@atmurray atmurray marked this pull request as ready for review August 31, 2024 08:50
@epenet epenet changed the title Acmeda integration bump aiopulse module to 0.4.6 Bump aiopulse to 0.4.6 Aug 31, 2024
@epenet
Copy link
Contributor

epenet commented Aug 31, 2024

Should this be included in 2024.9?

@atmurray
Copy link
Contributor Author

Would be nice, its a non-breaking change that resolves a couple of issues that have been problematic for a few users.

@epenet epenet added this to the 2024.9.0 milestone Aug 31, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive thanks for splitting the PRs btw. A lot of people see this as overhead, but now we can at least get some fixes in, while others wait for discussions :D

@joostlek joostlek merged commit 221f961 into home-assistant:dev Aug 31, 2024
40 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
@atmurray atmurray deleted the acmeda-aiopulse-0.4.6 branch September 8, 2024 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants