Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize hassfest image #124855

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Optimize hassfest image #124855

merged 5 commits into from
Aug 30, 2024

Conversation

edenhaus
Copy link
Contributor

@edenhaus edenhaus commented Aug 29, 2024

Breaking change

Proposed change

Optimize hassfest container image
Size reduced from 1.8GB -> 336MB
Execution time to verify hacs reduced from 52s -> 10s

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@edenhaus edenhaus requested a review from a team as a code owner August 29, 2024 11:47
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Aug 29, 2024
@edenhaus edenhaus force-pushed the edenhaus-optimize-hassfest-image branch from 2797f84 to 46effa4 Compare August 29, 2024 11:55
@edenhaus edenhaus force-pushed the edenhaus-optimize-hassfest-image branch from 46effa4 to d97c49d Compare August 29, 2024 15:21
@edenhaus edenhaus marked this pull request as draft August 29, 2024 15:21
@edenhaus
Copy link
Contributor Author

Successfully tested with https://github.com/home-assistant/core/actions/runs/10621424988/job/29443390815
I will tag it for beta as this PR changes only the hassfest image, which is only for custom components and will not used in production.
By tagging it for the beta all custom component benefit a month earlier for the smaller image

@edenhaus edenhaus added this to the 2024.9.0 milestone Aug 29, 2024
@edenhaus edenhaus marked this pull request as ready for review August 29, 2024 19:32
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@edenhaus edenhaus merged commit 397198c into dev Aug 30, 2024
40 checks passed
@edenhaus edenhaus deleted the edenhaus-optimize-hassfest-image branch August 30, 2024 11:09
bramkragten pushed a commit that referenced this pull request Aug 30, 2024
* Optimize hassfest docker image

* Adjust CI

* Use dynamic uv version

* Remove workaround
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants