Include all enphase_envoy devices in async_remove_config_entry_device #124533
Conversation
home-assistant
bot
added
cla-signed
code-quality
integration: enphase_envoy
small-pr
|
Hey there @bdraco, @cgarwood, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| if envoy_data and envoy_data.encharge_inventory: | ||
| for encharge in envoy_data.encharge_inventory: | ||
| if str(encharge) in dev_ids: | ||
| return False | ||
| if envoy_data and envoy_data.enpower: | ||
| if str(envoy_data.enpower.serial_number) in dev_ids: | ||
| return False |
There was a problem hiding this comment.
Can we maybe look into automatic deletion at some point?
There was a problem hiding this comment.
This was added (without the encharge and enpower that are now added) in #74012, a year before the overhaul of the integration. So I assume this one was needed then, as confirmation a device could be manually removed or not. I think it's only used to prevent the user to remove a device manually if there's still an envoy, inverters, encharge and enpower present. An actual delete will occur when removing the integration entry.
So something automatically can be done in a future PR but I think till now we only allow disable.
There was a problem hiding this comment.
Yes this code allows to delete manually. But if we can know from the API for sure that a device is gone, we can do that automatically
There was a problem hiding this comment.
Ok, I'll add it to my to-do list for an upcoming PR. Adding the encharge and enpower test is to prevent an accidental manual delete for now.
Proposed change
Currently Enphase_envoy only checks for the Envoy itself or any solar inverters in __init__.py::async_remove_config_entry_device. Enpower and Encharge devices are not checked.
This PR extends async_remove_config_entry_device to also check for Encharge and Enpower devices and if matched return false.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: