Add returning activity to Husqvarna lawn mower #124511

mikey0000 · 2024-08-23T21:01:14Z

Breaking change

Proposed change

Update the two mower integrations with returning activity

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-08-23T21:01:21Z

Hey there @Thomas55555, mind taking a look at this pull request as it has been labeled with an integration (husqvarna_automower) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of husqvarna_automower can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign husqvarna_automower Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant · 2024-08-23T21:01:22Z

Hey there @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign ecovacs Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Thomas55555 · 2024-08-24T05:35:23Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

    
           AutomowerBinarySensorEntityDescription( 
        
               key="returning_to_dock", 
        
               translation_key="returning_to_dock", 
        
               value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

joostlek · 2024-08-24T05:43:43Z

Please split this into two PRs

mikey0000 · 2024-08-24T05:53:28Z

Please split this into two PRs

Wondered if I'd get asked that, will do, I'll keep this one for one half and open a new one for the other

mikey0000 · 2024-08-24T06:16:29Z

Please split this into two PRs

Moved Ecovacs to here #124519

mikey0000 · 2024-08-24T06:17:28Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

AutomowerBinarySensorEntityDescription(

key="returning_to_dock",

translation_key="returning_to_dock",

value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

You or me doing that?

Thomas55555 · 2024-08-24T06:34:10Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

AutomowerBinarySensorEntityDescription(

key="returning_to_dock",

translation_key="returning_to_dock",

value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

You or me doing that?

I'm really busy right now. I can't do it within the next two weeks or something like that. So it would be nice, if you could do it.

mikey0000 · 2024-08-24T07:28:03Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

AutomowerBinarySensorEntityDescription(

key="returning_to_dock",

translation_key="returning_to_dock",

value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

You or me doing that?

I'm really busy right now. I can't do it within the next two weeks or something like that. So it would be nice, if you could do it.

Sweet as, happy to

mikey0000 · 2024-08-25T20:14:26Z

Please split this into two PRs

Can you update the labels? Or should I just reopen a new PR?

mikey0000 · 2024-08-26T04:49:02Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

AutomowerBinarySensorEntityDescription(

key="returning_to_dock",

translation_key="returning_to_dock",

value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

You or me doing that?

I'm really busy right now. I can't do it within the next two weeks or something like that. So it would be nice, if you could do it.

#124610

if your at least able to test this out?

Thomas55555 · 2024-08-26T13:59:06Z

There is a binary sensor for the same function. I think this should be deprecated in another PR.

core/homeassistant/components/husqvarna_automower/binary_sensor.py

Lines 42 to 45 in 7ae8f4c

AutomowerBinarySensorEntityDescription(

key="returning_to_dock",

translation_key="returning_to_dock",

value_fn=lambda data: data.mower.activity == MowerActivities.GOING_HOME,

Otherwise it looks good for me.

You or me doing that?

I'm really busy right now. I can't do it within the next two weeks or something like that. So it would be nice, if you could do it.

#124610

if your at least able to test this out?

Unfortunately not. But with a test we can be pretty sure, that it works.

Thomas55555

Please at a test here:

core/tests/components/husqvarna_automower/test_lawn_mower.py

Lines 43 to 47 in f4528b2

    
           for activity, state, expected_state in ( 
        
               ("UNKNOWN", "PAUSED", LawnMowerActivity.PAUSED), 
        
               ("MOWING", "NOT_APPLICABLE", LawnMowerActivity.MOWING), 
        
               ("NOT_APPLICABLE", "ERROR", LawnMowerActivity.ERROR), 
        
           ):

("GOING_HOME", "IN_OPERATION", LawnMowerActivity.RETURNING),

mikey0000 · 2024-08-29T01:55:58Z

Please at a test here:

core/tests/components/husqvarna_automower/test_lawn_mower.py

Lines 43 to 47 in f4528b2

for activity, state, expected_state in (

("UNKNOWN", "PAUSED", LawnMowerActivity.PAUSED),

("MOWING", "NOT_APPLICABLE", LawnMowerActivity.MOWING),

("NOT_APPLICABLE", "ERROR", LawnMowerActivity.ERROR),

):

("GOING_HOME", "IN_OPERATION", LawnMowerActivity.RETURNING),

Test added and passing.

Thomas55555

If the maintainers are okay with it, we can merge it.
Thanks @mikey0000 👍

mikey0000 requested review from mib1185 and edenhaus as code owners August 23, 2024 21:01

home-assistant bot added cla-signed integration: ecovacs integration: husqvarna_automower small-pr PRs with less than 30 lines. labels Aug 23, 2024

home-assistant bot assigned mib1185 Aug 23, 2024

home-assistant bot added the Quality Scale: No score label Aug 23, 2024

home-assistant bot assigned edenhaus Aug 23, 2024

add returning activity to husqvarna lawn mower

b8e0ecb

mikey0000 force-pushed the update-returning-lawn-mowers branch from 5af9276 to b8e0ecb Compare August 24, 2024 06:12

mikey0000 changed the title ~~add returning state to the two mowers in HA~~ Add returning activity to Husqvarna lawn mower Aug 24, 2024

mib1185 removed the integration: ecovacs label Aug 25, 2024

mib1185 removed request for edenhaus and mib1185 August 25, 2024 20:18

mib1185 assigned Thomas55555 and unassigned edenhaus and mib1185 Aug 25, 2024

Thomas55555 suggested changes Aug 26, 2024

View reviewed changes

Update test, fix bug with comparison operator

3f30597

mikey0000 requested a review from Thomas55555 August 29, 2024 01:56

Thomas55555 approved these changes Aug 29, 2024

View reviewed changes

joostlek approved these changes Aug 30, 2024

View reviewed changes

joostlek merged commit 54188b4 into home-assistant:dev Aug 30, 2024
26 checks passed

github-actions bot locked and limited conversation to collaborators Aug 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add returning activity to Husqvarna lawn mower #124511

Add returning activity to Husqvarna lawn mower #124511

mikey0000 commented Aug 23, 2024 •

edited

Loading

home-assistant bot commented Aug 23, 2024

home-assistant bot commented Aug 23, 2024

Thomas55555 commented Aug 24, 2024 •

edited

Loading

joostlek commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

Thomas55555 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 25, 2024

mikey0000 commented Aug 26, 2024

Thomas55555 commented Aug 26, 2024

Thomas55555 left a comment

mikey0000 commented Aug 29, 2024

Thomas55555 left a comment

	for activity, state, expected_state in (
	("UNKNOWN", "PAUSED", LawnMowerActivity.PAUSED),
	("MOWING", "NOT_APPLICABLE", LawnMowerActivity.MOWING),
	("NOT_APPLICABLE", "ERROR", LawnMowerActivity.ERROR),
	):

Add returning activity to Husqvarna lawn mower #124511

Add returning activity to Husqvarna lawn mower #124511

Conversation

mikey0000 commented Aug 23, 2024 • edited Loading

Breaking change

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Aug 23, 2024

home-assistant bot commented Aug 23, 2024

Thomas55555 commented Aug 24, 2024 • edited Loading

joostlek commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

Thomas55555 commented Aug 24, 2024

mikey0000 commented Aug 24, 2024

mikey0000 commented Aug 25, 2024

mikey0000 commented Aug 26, 2024

Thomas55555 commented Aug 26, 2024

Thomas55555 left a comment

Choose a reason for hiding this comment

mikey0000 commented Aug 29, 2024

Thomas55555 left a comment

Choose a reason for hiding this comment

mikey0000 commented Aug 23, 2024 •

edited

Loading

Thomas55555 commented Aug 24, 2024 •

edited

Loading