Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagnostics for BSBLan #124508

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

liudger
Copy link
Contributor

@liudger liudger commented Aug 23, 2024

Update diagnostics.
Fix entity mac address retrieval.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek joostlek changed the title Update diagnostics Update diagnostics for BSBLan Aug 23, 2024
@liudger liudger marked this pull request as ready for review August 24, 2024 07:59
@liudger
Copy link
Contributor Author

liudger commented Aug 30, 2024

@joostlek was it ok to merge this pull request?

@joostlek joostlek merged commit 252f05e into home-assistant:dev Aug 30, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
@mib1185 mib1185 added the bugfix label Sep 7, 2024
@mib1185 mib1185 added this to the 2024.9.2 milestone Sep 7, 2024
@mib1185
Copy link
Contributor

mib1185 commented Sep 7, 2024

tagged for 2024.9.2 since this is a bugfix, but missed to be tagged properly (see #125451)

@liudger liudger deleted the update-diagnostics branch September 13, 2024 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants